Review Request: CMake build directory deletion fix

Ivan Shapovalov intelfx100 at gmail.com
Wed May 2 02:38:43 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104806/
-----------------------------------------------------------

(Updated May 2, 2012, 2:38 a.m.)


Review request for KDevelop.


Changes
-------

Formatted patch (git format-patch)


Description
-------

CMake build directory chooser behaved incorrectly, disallowing deletion of any build directories.
Just a condition negation.


Diffs
-----

  projectmanagers/cmake/settings/cmakepreferences.cpp 09652e1 

Diff: http://git.reviewboard.kde.org/r/104806/diff/


Testing
-------

The fix is obvious. After applying, it works.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120502/fa7d29e6/attachment.html>


More information about the KDevelop-devel mailing list