Review Request: CMake build directory deletion fix

Aleix Pol Gonzalez aleixpol at gmail.com
Tue May 1 20:22:28 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104806/#review13249
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On May 1, 2012, 11:38 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104806/
> -----------------------------------------------------------
> 
> (Updated May 1, 2012, 11:38 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> CMake build directory chooser behaved incorrectly, disallowing deletion of any build directories.
> Just a condition negation.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/settings/cmakepreferences.cpp 09652e1 
> 
> Diff: http://git.reviewboard.kde.org/r/104806/diff/
> 
> 
> Testing
> -------
> 
> The fix is obvious. After applying, it works.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120501/c17da8fb/attachment.html>


More information about the KDevelop-devel mailing list