Review Request: CMake build directory deletion fix

Commit Hook null at kde.org
Thu May 3 08:35:58 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104806/#review13313
-----------------------------------------------------------


This review has been submitted with commit e4d670fd2936fb2c1229ec402dd02f547f437c43 by Ivan Shapovalov to branch 4.3.

- Commit Hook


On May 2, 2012, 2:38 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104806/
> -----------------------------------------------------------
> 
> (Updated May 2, 2012, 2:38 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> CMake build directory chooser behaved incorrectly, disallowing deletion of any build directories.
> Just a condition negation.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/settings/cmakepreferences.cpp 09652e1 
> 
> Diff: http://git.reviewboard.kde.org/r/104806/diff/
> 
> 
> Testing
> -------
> 
> The fix is obvious. After applying, it works.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120503/4c0f14a6/attachment.html>


More information about the KDevelop-devel mailing list