Review Request: Make sig assistant rename
Olivier Jean de Gaalon
olivier.jg at gmail.com
Tue Mar 6 10:47:46 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103817/
-----------------------------------------------------------
(Updated March 6, 2012, 10:47 a.m.)
Review request for KDevelop.
Changes
-------
Fix noted issues. Clean up surrounding code.
Description
-------
After editing function declaration, when updating the definition to match, rename uses of renamed declarations.
Note:
Removed the assistant stacking since the sig assist depends on being destroyed (and it was hacking where change is needed). Shouldn't be much work to fix that, but time I don't have now...
This addresses bug 255706.
http://bugs.kde.org/show_bug.cgi?id=255706
Diffs (updated)
-----
languages/cpp/CMakeLists.txt 830a3e3
languages/cpp/codegen/adaptsignatureaction.h PRE-CREATION
languages/cpp/codegen/adaptsignatureaction.cpp PRE-CREATION
languages/cpp/codegen/renameaction.h PRE-CREATION
languages/cpp/codegen/renameaction.cpp PRE-CREATION
languages/cpp/codegen/renameassistant.cpp 6ac1219
languages/cpp/codegen/signatureassistant.h 2c6853d
languages/cpp/codegen/signatureassistant.cpp dc53840
Diff: http://git.reviewboard.kde.org/r/103817/diff/
Testing
-------
Using the signature assistant.
Thanks,
Olivier Jean de Gaalon
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120306/fa81daf2/attachment.html>
More information about the KDevelop-devel
mailing list