Review Request: Make sig assistant rename

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103817/#review11472
-----------------------------------------------------------

Ship it!


ok, go for it (master branch), but I would *really* like to see some unit tests for this!


languages/cpp/codegen/signatureassistant.cpp
<http://git.reviewboard.kde.org/r/103817/#comment9148>

    you can use ENSURE_CHAIN_READ_LOCKED macro from duchainlock.h



languages/cpp/codegen/signatureassistant.cpp
<http://git.reviewboard.kde.org/r/103817/#comment9149>

    ENSURE_CHAIN_READ_LOCKED (like above)


- Milian Wolff


On March 6, 2012, 10:47 a.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103817/
> -----------------------------------------------------------
> 
> (Updated March 6, 2012, 10:47 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> After editing function declaration, when updating the definition to match, rename uses of renamed declarations.
> 
> Note:
> Removed the assistant stacking since the sig assist depends on being destroyed (and it was hacking where change is needed). Shouldn't be much work to fix that, but time I don't have now...
> 
> 
> This addresses bug 255706.
>     http://bugs.kde.org/show_bug.cgi?id=255706
> 
> 
> Diffs
> -----
> 
>   languages/cpp/CMakeLists.txt 830a3e3 
>   languages/cpp/codegen/adaptsignatureaction.h PRE-CREATION 
>   languages/cpp/codegen/adaptsignatureaction.cpp PRE-CREATION 
>   languages/cpp/codegen/renameaction.h PRE-CREATION 
>   languages/cpp/codegen/renameaction.cpp PRE-CREATION 
>   languages/cpp/codegen/renameassistant.cpp 6ac1219 
>   languages/cpp/codegen/signatureassistant.h 2c6853d 
>   languages/cpp/codegen/signatureassistant.cpp dc53840 
> 
> Diff: http://git.reviewboard.kde.org/r/103817/diff/
> 
> 
> Testing
> -------
> 
> Using the signature assistant.
> 
> 
> Thanks,
> 
> Olivier Jean de Gaalon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120316/37b25fc0/attachment.html>