Review Request: Custom build system: Use outputmodel from outputview

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105322/#review14985
-----------------------------------------------------------


Cool, I actually thought about starting on this myself over the weekend since I'm using KDev+CustomBuildsystem quite a bit again lately and not being able to click errors is so annoying. So thanks for doing the work.

That being said, I'd rather see the delegate being set in the constructor and not requiring a new member variable. Unless I'm overlooking something this shouldn't be a problem. If it turns out to be one, at least store just the delegate as member in the job and not the complete plugin.

- Andreas Pakulat


On June 21, 2012, 9:48 p.m., Morten Volden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105322/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 9:48 p.m.)
> 
> 
> Review request for Custom Buildsystem and KDevelop.
> 
> 
> Description
> -------
> 
> This patch is related to: http://git.reviewboard.kde.org/r/104814/
> (Share code between makebuilder and external scripts). It uses the outputmodel defined in outputview/outputmodel to get colored, activatable errors in the output window (See screenshots in http://git.reviewboard.kde.org/r/104814/) 
> 
> 
> Diffs
> -----
> 
>   custombuildjob.h b784070 
>   custombuildjob.cpp dd25842 
>   custombuildsystemplugin.h 78541d2 
>   custombuildsystemplugin.cpp 0b5ef3e 
> 
> Diff: http://git.reviewboard.kde.org/r/105322/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Morten Volden
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120622/0e49e689/attachment.html>