Review Request: Custom build system: Use outputmodel from outputview

Morten Volden mvolden2 at gmail.com
Fri Jun 22 15:01:19 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105322/
-----------------------------------------------------------

(Updated June 22, 2012, 3:01 p.m.)


Review request for Custom Buildsystem and KDevelop.


Changes
-------

Set the delegate in the ctor, to avoid having the plugin as a member of custombuildjob


Description
-------

This patch is related to: http://git.reviewboard.kde.org/r/104814/
(Share code between makebuilder and external scripts). It uses the outputmodel defined in outputview/outputmodel to get colored, activatable errors in the output window (See screenshots in http://git.reviewboard.kde.org/r/104814/) 


Diffs (updated)
-----

  custombuildjob.h b784070 
  custombuildjob.cpp dd25842 
  custombuildsystemplugin.h 78541d2 
  custombuildsystemplugin.cpp 0b5ef3e 

Diff: http://git.reviewboard.kde.org/r/105322/diff/


Testing
-------


Thanks,

Morten Volden

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120622/8d712473/attachment.html>


More information about the KDevelop-devel mailing list