<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105322/">http://git.reviewboard.kde.org/r/105322/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cool, I actually thought about starting on this myself over the weekend since I'm using KDev+CustomBuildsystem quite a bit again lately and not being able to click errors is so annoying. So thanks for doing the work.
That being said, I'd rather see the delegate being set in the constructor and not requiring a new member variable. Unless I'm overlooking something this shouldn't be a problem. If it turns out to be one, at least store just the delegate as member in the job and not the complete plugin.</pre>
<br />
<p>- Andreas</p>
<br />
<p>On June 21st, 2012, 9:48 p.m., Morten Volden wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Custom Buildsystem and KDevelop.</div>
<div>By Morten Volden.</div>
<p style="color: grey;"><i>Updated June 21, 2012, 9:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is related to: http://git.reviewboard.kde.org/r/104814/
(Share code between makebuilder and external scripts). It uses the outputmodel defined in outputview/outputmodel to get colored, activatable errors in the output window (See screenshots in http://git.reviewboard.kde.org/r/104814/) </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>custombuildjob.h <span style="color: grey">(b784070)</span></li>
<li>custombuildjob.cpp <span style="color: grey">(dd25842)</span></li>
<li>custombuildsystemplugin.h <span style="color: grey">(78541d2)</span></li>
<li>custombuildsystemplugin.cpp <span style="color: grey">(0b5ef3e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105322/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>