kdevplatform textdocument.cpp

Milian Wolff mail at milianw.de
Wed Feb 29 18:30:40 UTC 2012

On Tuesday 28 February 2012 23:35:16 Lambert CLARA wrote:
> Hello,
> I noticed when working on my bookmarks patch that since 82cc03546384d,
> TextDocument::close() method in shell/textdocument.cpp is not called
> anymore when I close a file tab, but only when exitting kdevelop completely.
> Was this intended ? i.e. should I find a new place for the KTextEditor
> writeSessionConfig part of my patch :) ?

I've investigated this:

First up, close() is not really called at all. Most of the time, the document 
is simply deleted without ever being closed.

So, this is such a huge mess I'd be against even trying to fix it for 1.3... 
Instead please just push your code into a reusable method in 
TextDocumentPrivate that  is called a) in close() and b) from 
~TextDocumentPrivate before the document is deleted (if it's still there)

so that should do the trick

Milian Wolff
mail at milianw.de

More information about the KDevelop-devel mailing list