Review Request: Do not bail out on rename if src==dest

Kevin Funk krf at
Tue Dec 4 23:57:43 UTC 2012

This is an automatically generated e-mail. To reply, visit:

Review request for KDevelop and Andreas Pakulat.


Do not bail out on rename if src==dest

* In case source and destination are equal, just return RenameOk
  (this is the same behavior as std::rename has, when src==dest)
* Simplify both folder item's and file item's rename method by
  returning early in case the rename target is invalid
* Add new tests for folder, build folder and file items

BUG: 311151


  project/projectmodel.cpp 613ddb512d0f1909d5e74451146bf3138421a6a0 
  project/tests/projectmodeltest.cpp 4277b0c7e5b607fc9b50b9e0b24370ff0bdcd22f 




Kevin Funk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list