Review Request: Do not bail out on rename if src==dest

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107585/#review23000
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On Dec. 4, 2012, 11:57 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107585/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2012, 11:57 p.m.)
> 
> 
> Review request for KDevelop and Andreas Pakulat.
> 
> 
> Description
> -------
> 
> Do not bail out on rename if src==dest
> 
> * In case source and destination are equal, just return RenameOk
>   (this is the same behavior as std::rename has, when src==dest)
> * Simplify both folder item's and file item's rename method by
>   returning early in case the rename target is invalid
> * Add new tests for folder, build folder and file items
> 
> BUG: 311151
> 
> 
> Diffs
> -----
> 
>   project/projectmodel.cpp 613ddb512d0f1909d5e74451146bf3138421a6a0 
>   project/tests/projectmodeltest.cpp 4277b0c7e5b607fc9b50b9e0b24370ff0bdcd22f 
> 
> Diff: http://git.reviewboard.kde.org/r/107585/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121205/95efb51d/attachment.html>