Review Request: Load appwizard templates from files

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105009/#review17558
-----------------------------------------------------------


can we close this review request? once we merge your gsoc branch, this feature gets in anyways, no?

- Milian Wolff


On June 3, 2012, 6:55 p.m., Miha Čančula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105009/
> -----------------------------------------------------------
> 
> (Updated June 3, 2012, 6:55 p.m.)
> 
> 
> Review request for KDevelop, Milian Wolff and Alexander Dymo.
> 
> 
> Description
> -------
> 
> Implement loading templates from local file. Lodaded templates are immediately selected for convenience. Their descriptions are extracted, but their icons are not. I will add icon-extraction after the initial code is reviewed. The archive files are copied to a ~/.kde/share/apps/kdevappwizard/templates/ where the existing code picks them up. 
> 
> Templates can also be downloaded from kde-files, from the "New Project" dialog (first screenshot). So far there are only two templates there, and they both work as expected. 
> 
> Additionally, I enabled loading .kdevtemplate files directly and compressing the containing directory. 
> 
> Last, there is a new page in KDevelop settings, where templates can be imported, downloaded or uploaded. Because this page share most of the functionality (especially the model) with the "New Project" dialog, I moved some of the code from plugins/appwizard to language/codegen. It will also be useful for implementing file templates. 
> 
> 
> Diffs
> -----
> 
>   interfaces/CMakeLists.txt c3e072d125a084f31f81b75640bb52077a9ee51c 
>   interfaces/itemplateprovider.h PRE-CREATION 
>   interfaces/itemplateprovider.cpp PRE-CREATION 
>   language/CMakeLists.txt 8efd967db3dbc5bf503ce33033555bd712fa7896 
>   language/codegen/multilevellistview.h PRE-CREATION 
>   language/codegen/multilevellistview.cpp PRE-CREATION 
>   language/codegen/templatesmodel.h PRE-CREATION 
>   language/codegen/templatesmodel.cpp PRE-CREATION 
>   plugins/CMakeLists.txt f401c830bfbde9f7153b7a084a0a8889ac9ec111 
>   plugins/appwizard/CMakeLists.txt 0e2119197765ad514b8827fda5afe7254f8ea788 
>   plugins/appwizard/appwizardplugin.h 51333b19c56f6898f1b537a40e33918a2f92c574 
>   plugins/appwizard/appwizardplugin.cpp cac268a57a5a75ab1bae92b3150d1e4b5ea03ae9 
>   plugins/appwizard/kdevappwizard.desktop 2ebe59b96d5273c167134edec4f2086135187c63 
>   plugins/appwizard/kdevappwizard.knsrc PRE-CREATION 
>   plugins/appwizard/projectselectionpage.h 745a1efa1d00c2ac4fe215b7242cf2ed09981e9e 
>   plugins/appwizard/projectselectionpage.cpp 373c66f7e1218858651d38678cc1010b4764308a 
>   plugins/appwizard/projectselectionpage.ui 7a33fdd2c68831776ea5dc8d7259afa831854a41 
>   plugins/appwizard/projecttemplatesmodel.h cbd91e976e1472dc29d9bc263268bf71d86ec229 
>   plugins/appwizard/projecttemplatesmodel.cpp 1fe09efec92d85c71679648408e8972b1ddd4971 
>   plugins/templatemanager/CMakeLists.txt PRE-CREATION 
>   plugins/templatemanager/kdevtemplatemanager_config.desktop PRE-CREATION 
>   plugins/templatemanager/templateconfig.h PRE-CREATION 
>   plugins/templatemanager/templateconfig.cpp PRE-CREATION 
>   plugins/templatemanager/templateconfig.ui PRE-CREATION 
>   plugins/templatemanager/templatepage.h PRE-CREATION 
>   plugins/templatemanager/templatepage.cpp PRE-CREATION 
>   plugins/templatemanager/templatepage.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105009/diff/
> 
> 
> Testing
> -------
> 
> Tested locally, archives shipped with KAppTemplate are loaded (as either archive files or uncompressed directories) successfully. 
> 
> Both downloading and uploading with KNewStuff works. 
> 
> 
> Screenshots
> -----------
> 
> New buttons in template selection
>   http://git.reviewboard.kde.org/r/105009/s/575/
> Template Settings
>   http://git.reviewboard.kde.org/r/105009/s/589/
> 
> 
> Thanks,
> 
> Miha Čančula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120816/f3b50e47/attachment.html>