Review Request: Custom build system: Use outputmodel from outputview

[Andreas Pakulat]

> On June 22, 2012, 8:37 p.m., Andreas Pakulat wrote:
> > Patch looks good now, thanks for you work on this. Please commit as soon as the other patches (which are required if I understood correctly) have landed in kdevplatform/kdevelop master or send me the patches as produced with git format-patch and I'll commit them.
> 
> Milian Wolff wrote:
>     was this applied? i.e. can I close this review?

Yeap, otherwise I wouldn't have noticed the breakage in the "go to next/previous output mark" shortcuts :)


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105322/#review15026
-----------------------------------------------------------


On June 22, 2012, 7:11 p.m., Morten Volden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105322/
> -----------------------------------------------------------
> 
> (Updated June 22, 2012, 7:11 p.m.)
> 
> 
> Review request for Custom Buildsystem and KDevelop.
> 
> 
> Description
> -------
> 
> This patch is related to: http://git.reviewboard.kde.org/r/104814/
> (Share code between makebuilder and external scripts). It uses the outputmodel defined in outputview/outputmodel to get colored, activatable errors in the output window (See screenshots in http://git.reviewboard.kde.org/r/104814/) 
> 
> 
> Diffs
> -----
> 
>   custombuildjob.cpp dd25842 
>   custombuildsystemplugin.h 78541d2 
>   custombuildsystemplugin.cpp 0b5ef3e 
> 
> Diff: http://git.reviewboard.kde.org/r/105322/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Morten Volden
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120817/b8e3b933/attachment.html>