<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105009/">http://git.reviewboard.kde.org/r/105009/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">can we close this review request? once we merge your gsoc branch, this feature gets in anyways, no?</pre>
 <br />







<p>- Milian</p>


<br />
<p>On June 3rd, 2012, 6:55 p.m., Miha Čančula wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDevelop, Milian Wolff and Alexander Dymo.</div>
<div>By Miha Čančula.</div>


<p style="color: grey;"><i>Updated June 3, 2012, 6:55 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implement loading templates from local file. Lodaded templates are immediately selected for convenience. Their descriptions are extracted, but their icons are not. I will add icon-extraction after the initial code is reviewed. The archive files are copied to a ~/.kde/share/apps/kdevappwizard/templates/ where the existing code picks them up. 

Templates can also be downloaded from kde-files, from the "New Project" dialog (first screenshot). So far there are only two templates there, and they both work as expected. 

Additionally, I enabled loading .kdevtemplate files directly and compressing the containing directory. 

Last, there is a new page in KDevelop settings, where templates can be imported, downloaded or uploaded. Because this page share most of the functionality (especially the model) with the "New Project" dialog, I moved some of the code from plugins/appwizard to language/codegen. It will also be useful for implementing file templates. </pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested locally, archives shipped with KAppTemplate are loaded (as either archive files or uncompressed directories) successfully. 

Both downloading and uploading with KNewStuff works. </pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>interfaces/CMakeLists.txt <span style="color: grey">(c3e072d125a084f31f81b75640bb52077a9ee51c)</span></li>

 <li>interfaces/itemplateprovider.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>interfaces/itemplateprovider.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>language/CMakeLists.txt <span style="color: grey">(8efd967db3dbc5bf503ce33033555bd712fa7896)</span></li>

 <li>language/codegen/multilevellistview.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>language/codegen/multilevellistview.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>language/codegen/templatesmodel.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>language/codegen/templatesmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/CMakeLists.txt <span style="color: grey">(f401c830bfbde9f7153b7a084a0a8889ac9ec111)</span></li>

 <li>plugins/appwizard/CMakeLists.txt <span style="color: grey">(0e2119197765ad514b8827fda5afe7254f8ea788)</span></li>

 <li>plugins/appwizard/appwizardplugin.h <span style="color: grey">(51333b19c56f6898f1b537a40e33918a2f92c574)</span></li>

 <li>plugins/appwizard/appwizardplugin.cpp <span style="color: grey">(cac268a57a5a75ab1bae92b3150d1e4b5ea03ae9)</span></li>

 <li>plugins/appwizard/kdevappwizard.desktop <span style="color: grey">(2ebe59b96d5273c167134edec4f2086135187c63)</span></li>

 <li>plugins/appwizard/kdevappwizard.knsrc <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/appwizard/projectselectionpage.h <span style="color: grey">(745a1efa1d00c2ac4fe215b7242cf2ed09981e9e)</span></li>

 <li>plugins/appwizard/projectselectionpage.cpp <span style="color: grey">(373c66f7e1218858651d38678cc1010b4764308a)</span></li>

 <li>plugins/appwizard/projectselectionpage.ui <span style="color: grey">(7a33fdd2c68831776ea5dc8d7259afa831854a41)</span></li>

 <li>plugins/appwizard/projecttemplatesmodel.h <span style="color: grey">(cbd91e976e1472dc29d9bc263268bf71d86ec229)</span></li>

 <li>plugins/appwizard/projecttemplatesmodel.cpp <span style="color: grey">(1fe09efec92d85c71679648408e8972b1ddd4971)</span></li>

 <li>plugins/templatemanager/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/templatemanager/kdevtemplatemanager_config.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/templatemanager/templateconfig.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/templatemanager/templateconfig.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/templatemanager/templateconfig.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/templatemanager/templatepage.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/templatemanager/templatepage.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/templatemanager/templatepage.ui <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105009/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/105009/s/575/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/05/23/kdev-appwizard-buttons_400x100.png" style="border: 1px black solid;" alt="New buttons in template selection" /></a>

 <a href="http://git.reviewboard.kde.org/r/105009/s/589/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/06/03/kdev-template-manager_400x100.png" style="border: 1px black solid;" alt="Template Settings" /></a>

</div>


  </td>
 </tr>
</table>








  </div>
 </body>
</html>