Review Request: Fix zip invocation on Windows
Milian Wolff
mail at milianw.de
Thu Aug 16 19:29:44 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105985/#review17554
-----------------------------------------------------------
Ship it!
+1 from my side as well, can you commit this on your own?
- Milian Wolff
On Aug. 11, 2012, 9:18 p.m., Steffen Ohrendorf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105985/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2012, 9:18 p.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> This fixes the invocation of InfoZIP on Windows which requires the exclusion parameter to be the last one on the command line.
>
>
> Diffs
> -----
>
> cmake/modules/KDevPlatformMacros.cmake f960e82
>
> Diff: http://git.reviewboard.kde.org/r/105985/diff/
>
>
> Testing
> -------
>
> KDevPlatform successfully zips the app templates.
>
>
> Thanks,
>
> Steffen Ohrendorf
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120816/db2bb5ea/attachment.html>
More information about the KDevelop-devel
mailing list