Review Request: Fix zip invocation on Windows

Andreas Pakulat apaku at gmx.de
Mon Aug 13 18:37:23 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105985/#review17334
-----------------------------------------------------------

Ship it!


emerge fetches it from the gnuwin32 project. That its not packaged atm for binary packages is probably simply due to no app requiring it, that would change once kdevelop would be packaged...

So ok from my side until someone comes around with a different zip-tool, then we really need to look into detecting the tool I guess.

- Andreas Pakulat


On Aug. 11, 2012, 9:18 p.m., Steffen Ohrendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105985/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2012, 9:18 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This fixes the invocation of InfoZIP on Windows which requires the exclusion parameter to be the last one on the command line.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/KDevPlatformMacros.cmake f960e82 
> 
> Diff: http://git.reviewboard.kde.org/r/105985/diff/
> 
> 
> Testing
> -------
> 
> KDevPlatform successfully zips the app templates.
> 
> 
> Thanks,
> 
> Steffen Ohrendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120813/45dc9826/attachment.html>


More information about the KDevelop-devel mailing list