Review Request: C99 designated initializers (fix)

[Alexandre Courbot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104557/#review12378
-----------------------------------------------------------


Cool, this seems to parse all tests cases without causing any trouble, indeed. I will use it for a couple of days to see how it behaves.

On top of the inline comment I did, I think we should try to invert the order of

parseInitializerList(list, true) || parseInitializerList(list, false)

The reason is that as Milian mentionned, designated initializers are not the most common case and should be checked last (I am not sure whether this introduces a large overhead, but he has a point). Also these functions should be able to proceed in any order - the impossibility to do so seems to indicate one of parseAssignmentExpression or parseBracedInitList does not restore the context correctly.

- Alexandre Courbot


On April 13, 2012, 1:18 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104557/
> -----------------------------------------------------------
> 
> (Updated April 13, 2012, 1:18 a.m.)
> 
> 
> Review request for KDevelop and Alexandre Courbot.
> 
> 
> Description
> -------
> 
> Fix of this patch:
> https://git.reviewboard.kde.org/r/103448
> 
> Passes unit-tests and "QString" testcase.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/parser/parser.h 64b5c50 
>   languages/cpp/parser/parser.cpp a45ee31 
>   languages/cpp/parser/tests/test_parser.h 2869d9d 
>   languages/cpp/parser/tests/test_parser.cpp 94e3ee0 
> 
> Diff: http://git.reviewboard.kde.org/r/104557/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120413/c0e5917d/attachment.html>