Review Request: C99 designated initializers (fix)

[Alexandre Courbot]

> On April 13, 2012, 5:54 a.m., Alexandre Courbot wrote:
> > languages/cpp/parser/parser.cpp, line 2776
> > <http://git.reviewboard.kde.org/r/104557/diff/1/?file=56379#file56379line2776>
> >
> >     Isn't that equivalent to having
> >     
> >     parseDesignatedInitializer(expr) || parseAssignmentExpression(expr) || parseBracedInitList(expr);
> >     
> >     in parseInitializer clause? It does not seem necessary to have this additional argument.
> 
> Alexandre Courbot wrote:
>     Well obviously there is an effect because if I change it back to this the string case does not pass anymore. I fail to see the connection though.

Ok, I got it now - we should not (and need not) check for designated initializers for every initializer case. And having designated initializers checked first does not hurt at all since only two tokens are checked before it returns. This patch looks good, I will revise mine based on this if you allow so.


- Alexandre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104557/#review12377
-----------------------------------------------------------


On April 13, 2012, 1:18 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104557/
> -----------------------------------------------------------
> 
> (Updated April 13, 2012, 1:18 a.m.)
> 
> 
> Review request for KDevelop and Alexandre Courbot.
> 
> 
> Description
> -------
> 
> Fix of this patch:
> https://git.reviewboard.kde.org/r/103448
> 
> Passes unit-tests and "QString" testcase.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/parser/parser.h 64b5c50 
>   languages/cpp/parser/parser.cpp a45ee31 
>   languages/cpp/parser/tests/test_parser.h 2869d9d 
>   languages/cpp/parser/tests/test_parser.cpp 94e3ee0 
> 
> Diff: http://git.reviewboard.kde.org/r/104557/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120413/d238ecc8/attachment.html>