<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104557/">http://git.reviewboard.kde.org/r/104557/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cool, this seems to parse all tests cases without causing any trouble, indeed. I will use it for a couple of days to see how it behaves.
On top of the inline comment I did, I think we should try to invert the order of
parseInitializerList(list, true) || parseInitializerList(list, false)
The reason is that as Milian mentionned, designated initializers are not the most common case and should be checked last (I am not sure whether this introduces a large overhead, but he has a point). Also these functions should be able to proceed in any order - the impossibility to do so seems to indicate one of parseAssignmentExpression or parseBracedInitList does not restore the context correctly.</pre>
<br />
<p>- Alexandre</p>
<br />
<p>On April 13th, 2012, 1:18 a.m., Ivan Shapovalov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Alexandre Courbot.</div>
<div>By Ivan Shapovalov.</div>
<p style="color: grey;"><i>Updated April 13, 2012, 1:18 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix of this patch:
https://git.reviewboard.kde.org/r/103448
Passes unit-tests and "QString" testcase.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/parser/parser.h <span style="color: grey">(64b5c50)</span></li>
<li>languages/cpp/parser/parser.cpp <span style="color: grey">(a45ee31)</span></li>
<li>languages/cpp/parser/tests/test_parser.h <span style="color: grey">(2869d9d)</span></li>
<li>languages/cpp/parser/tests/test_parser.cpp <span style="color: grey">(94e3ee0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104557/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>