Patches for git plugin related reviews
sir.vestnik at gmail.com
Wed Oct 19 02:14:20 UTC 2011
On Tuesday 18 October 2011 23:40:08 Milian Wolff wrote:
> On Monday 17 October 2011 10:14:50 Sergey Vidyuk wrote:
> > Hello
> > Patches for reviews
> > https://git.reviewboard.kde.org/r/102850/
> > https://git.reviewboard.kde.org/r/102857/
> > https://git.reviewboard.kde.org/r/102858/
> > are attached. Patch for 102857 is modified following the last suggestion
> > from Milian. I've also uploaded modified version into reviewboard. I'm
> > unsure if it's good idea to have cpp file for implementation of one
> > empty
> > function. Actually I'm unsure if it's good idea to have non-pure virtual
> > function in an interface. If needed I can move implementation back to
> > header or into plugins.
> Pushed now. One question: Does the tooltip work for you? I couldn't get it
> to show up, i.e. the user does not see the error message of why a long line
> is too long and why it should be reduced...
No I can't see tooltip as well. I'll figure out why and fix it during this week.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 198 bytes
Desc: This is a digitally signed message part.
More information about the KDevelop-devel