Patches for git plugin related reviews

[Milian Wolff]

On Monday 17 October 2011 10:14:50 Sergey Vidyuk wrote:
> Hello
> 
> Patches for reviews
> https://git.reviewboard.kde.org/r/102850/
> https://git.reviewboard.kde.org/r/102857/
> https://git.reviewboard.kde.org/r/102858/
> are attached. Patch for 102857 is modified following the last suggestion
> from Milian. I've also uploaded modified version into reviewboard. I'm
> unsure if it's good idea to have cpp file for implementation of one empty
> function. Actually I'm unsure if it's good idea to have non-pure virtual
> function in an interface. If needed I can move implementation back to
> header or into plugins.

Pushed now. One question: Does the tooltip work for you? I couldn't get it to 
show up, i.e. the user does not see the error message of why a long line is 
too long and why it should be reduced...

bye
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111018/16987f58/attachment.sig>