Review Request: Avoid Resetting UI Delegates

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103285/#review8584
-----------------------------------------------------------


I'm personally split on this one (hence no ship it yet). IMHO this merely shows two bugs: One in the plugin registering a KIO::job and another one in kdelibs code that makes the job code crash when the delegate is a non-KIO specialized one. See also my comment on the bugreport.

Maybe add an a qAssert() (or something similar which shows an error in debug-mode) in the else() branch so that developers notify they're doing something wrong.

But I'd like to see more opinions from the developers.

- Andreas Pakulat


On Nov. 28, 2011, 8:17 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103285/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2011, 8:17 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Avoiding so decreases chances that bugs similar to bug 284148 happen again (it closes that bug, in particular). Notice that it would now be the responsibility of the KDevelop::RunController::registerJob(KJob *) caller to set the UI Delegate it wants to use before the call in case the job requires a UI Delegate different from KDialogJobUiDelegate (see the discussion in the bug report for a reason for that). 
> 
> 
> This addresses bug 284148.
>     http://bugs.kde.org/show_bug.cgi?id=284148
> 
> 
> Diffs
> -----
> 
>   shell/runcontroller.cpp 421a232 
> 
> Diff: http://git.reviewboard.kde.org/r/103285/diff/diff
> 
> 
> Testing
> -------
> 
> I've been using this patch for about three weeks with no problems related to the UI Delegate.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111128/441c35cd/attachment.html>