Review Request: Avoid Resetting UI Delegates

David Narváez david.narvaez at computer.org
Mon Nov 28 20:17:06 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103285/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

Avoiding so decreases chances that bugs similar to bug 284148 happen again (it closes that bug, in particular). Notice that it would now be the responsibility of the KDevelop::RunController::registerJob(KJob *) caller to set the UI Delegate it wants to use before the call in case the job requires a UI Delegate different from KDialogJobUiDelegate (see the discussion in the bug report for a reason for that). 


This addresses bug 284148.
    http://bugs.kde.org/show_bug.cgi?id=284148


Diffs
-----

  shell/runcontroller.cpp 421a232 

Diff: http://git.reviewboard.kde.org/r/103285/diff/diff


Testing
-------

I've been using this patch for about three weeks with no problems related to the UI Delegate.


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111128/85df865a/attachment.html>


More information about the KDevelop-devel mailing list