<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103285/">http://git.reviewboard.kde.org/r/103285/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm personally split on this one (hence no ship it yet). IMHO this merely shows two bugs: One in the plugin registering a KIO::job and another one in kdelibs code that makes the job code crash when the delegate is a non-KIO specialized one. See also my comment on the bugreport.
Maybe add an a qAssert() (or something similar which shows an error in debug-mode) in the else() branch so that developers notify they're doing something wrong.
But I'd like to see more opinions from the developers.</pre>
<br />
<p>- Andreas</p>
<br />
<p>On November 28th, 2011, 8:17 p.m., David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Nov. 28, 2011, 8:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Avoiding so decreases chances that bugs similar to bug 284148 happen again (it closes that bug, in particular). Notice that it would now be the responsibility of the KDevelop::RunController::registerJob(KJob *) caller to set the UI Delegate it wants to use before the call in case the job requires a UI Delegate different from KDialogJobUiDelegate (see the discussion in the bug report for a reason for that). </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've been using this patch for about three weeks with no problems related to the UI Delegate.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=284148">284148</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/runcontroller.cpp <span style="color: grey">(421a232)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103285/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>