Review Request: Checking infrastructure for the KDevPlatform

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103071/#review8017
-----------------------------------------------------------


some more style nitpicks, sorry Aleix ;-)


language/checks/controlflowgraph.cpp
<http://git.reviewboard.kde.org/r/103071/#comment6901>

    rtrim :)



language/checks/controlflownode.cpp
<http://git.reviewboard.kde.org/r/103071/#comment6903>

    personally I'd prefer if these methods
    are formatted like any other, i.e.:
    
    func signature()
    {
      m_bla = foo;
    }
    
    func2 signature()
    {...



language/checks/controlflownode.cpp
<http://git.reviewboard.kde.org/r/103071/#comment6902>

    spaces around operators please :)



language/checks/dataaccess.h
<http://git.reviewboard.kde.org/r/103071/#comment6904>

    spaces around operators please :)



language/checks/dataaccess.cpp
<http://git.reviewboard.kde.org/r/103071/#comment6905>

    also please format it properly (see above)



language/checks/dataaccessrepository.h
<http://git.reviewboard.kde.org/r/103071/#comment6906>

    spaces around operator please :)



language/checks/dataaccessrepository.cpp
<http://git.reviewboard.kde.org/r/103071/#comment6907>

    rtrim please :)


- Milian Wolff


On Nov. 8, 2011, 2:03 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103071/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2011, 2:03 a.m.)
> 
> 
> Review request for KDevelop, Milian Wolff and David Nolden.
> 
> 
> Description
> -------
> 
> As some of you will know, my master thesis was built on top of kdevelop with the idea to add some static analysis capabilities to KDevelop/KDevPlatform by adding some new tools and stuff. A document describing what I did can be found here: http://proli.net/meu/pfc/memoria.pdf
> 
> In this patch there's the changes I made in the KDevPlatform, mostly to add the DataAccessRepository and the ControlFlowGraph (Chapter 2) data types and the ILanguageCheck and ILanguageCheck provider (Chapter 3).
> 
> If there's any question just ask me :). I'll submit another patch for KDevelop, implementing these features shortly.
> 
> 
> Diffs
> -----
> 
>   language/CMakeLists.txt eb85b2c 
>   language/backgroundparser/parsejob.h 135319c 
>   language/checks/controlflowgraph.h PRE-CREATION 
>   language/checks/controlflowgraph.cpp PRE-CREATION 
>   language/checks/controlflownode.h PRE-CREATION 
>   language/checks/controlflownode.cpp PRE-CREATION 
>   language/checks/dataaccess.h PRE-CREATION 
>   language/checks/dataaccess.cpp PRE-CREATION 
>   language/checks/dataaccessrepository.h PRE-CREATION 
>   language/checks/dataaccessrepository.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103071/diff/diff
> 
> 
> Testing
> -------
> 
> Well, the testing is what I've built on top. It's coming, I'm just fixing some issues after merging from master. It wasn't as bad as I expected though ;).
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111108/0516411b/attachment.html>