<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103071/">http://git.reviewboard.kde.org/r/103071/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">some more style nitpicks, sorry Aleix ;-)</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103071/diff/5/?file=40642#file40642line63" style="color: black; font-weight: bold; text-decoration: underline;">language/checks/controlflowgraph.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void clearNodeRecursively(ControlFlowNode* node, QSet<ControlFlowNode*>& deleted)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">rtrim :)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103071/diff/5/?file=40644#file40644line42" style="color: black; font-weight: bold; text-decoration: underline;">language/checks/controlflownode.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ControlFlowNode::setConditionRange(const RangeInRevision& range)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">ControlFlowNode</span><span class="o">::</span><span class="n">setStartCursor</span><span class="p">(</span><span class="k">const</span> <span class="n">CursorInRevision</span><span class="o">&</span> <span class="n">cursor</span><span class="p">)</span> <span class="p">{</span> <span class="n">m_nodeRange</span><span class="p">.</span><span class="n">start</span> <span class="o">=</span> <span class="n">cursor</span><span class="p">;</span> <span class="p">}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">personally I'd prefer if these methods
are formatted like any other, i.e.:
func signature()
{
m_bla = foo;
}
func2 signature()
{...</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103071/diff/5/?file=40644#file40644line44" style="color: black; font-weight: bold; text-decoration: underline;">language/checks/controlflownode.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ControlFlowNode::setConditionRange(const RangeInRevision& range)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">ControlFlowNode</span><span class="o">::</span><span class="n">setNext</span><span class="p">(</span><span class="n">ControlFlowNode</span><span class="o">*</span> <span class="n">next</span><span class="p">)</span> <span class="p">{</span> <span class="n">m_next</span><span class="o">=</span><span class="n">next</span><span class="p">;</span> <span class="p">}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">spaces around operators please :)</pre>
</div>
<br />
<div>
<table class="sidebyside diff-error"
id="file_container_40645">
<thead>
<tr>
<th colspan="2" class="filename">
<a href="/r/103071/diff/5/?file=40645#file40645line40">language/checks/dataaccess.h</a>
<span class="diffrevision">
(Diff revision 5)
</span>
</tr>
</thead>
<tbody>
<tr>
<td colspan="2">Diff currently unavailable.</td>
</tr>
<tr>
<td colspan="2"><b>Error:</b> [Errno 12] Cannot allocate memory</td>
</tr>
<tr>
<td colspan="2">
<a id="diff-error-link-40645" href="#"
onclick="$('#diff-error-details-40645').toggle(); return false;">Details</a>
</td>
</tr>
<tr class="error-details" id="diff-error-details-40645">
<td colspan="2">
<pre>Traceback (most recent call last):
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/reviews/views.py", line 177, in build_diff_comment_fragments
comment.num_lines)),
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 1168, in get_file_chunks_in_range
get_enable_highlighting(context['user']))
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 1032, in get_diff_files
tool = filediff.diffset.repository.get_scmtool()
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/models.py", line 122, in get_scmtool
return cls(self)
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/git.py", line 70, in __init__
local_site_name)
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/git.py", line 307, in __init__
'core.repositoryformatversion'])
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/git.py", line 383, in _run_git
local_site_name=self.local_site_name)
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/core.py", line 122, in popen
close_fds=(os.name != 'nt'))
File "/usr/lib/python2.6/subprocess.py", line 633, in __init__
errread, errwrite)
File "/usr/lib/python2.6/subprocess.py", line 1049, in _execute_child
self.pid = os.fork()
OSError: [Errno 12] Cannot allocate memory
</pre>
</td>
</tr>
</tbody>
</table>
<script type="text/javascript">
/* Add to the change index. */
$("li.change_file_None").html(
'\
<a href="#None" onclick="return !gotoAnchor(\'None\');"></a>\
\
(was language/checks/dataaccess.h)\
\
:\
\
Diff currently unavailable.\
\
');
</script>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">spaces around operators please :)</pre>
</div>
<br />
<div>
<table class="sidebyside diff-error"
id="file_container_40646">
<thead>
<tr>
<th colspan="2" class="filename">
<a href="/r/103071/diff/5/?file=40646#file40646line27">language/checks/dataaccess.cpp</a>
<span class="diffrevision">
(Diff revision 5)
</span>
</tr>
</thead>
<tbody>
<tr>
<td colspan="2">Diff currently unavailable.</td>
</tr>
<tr>
<td colspan="2"><b>Error:</b> [Errno 12] Cannot allocate memory</td>
</tr>
<tr>
<td colspan="2">
<a id="diff-error-link-40646" href="#"
onclick="$('#diff-error-details-40646').toggle(); return false;">Details</a>
</td>
</tr>
<tr class="error-details" id="diff-error-details-40646">
<td colspan="2">
<pre>Traceback (most recent call last):
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/reviews/views.py", line 177, in build_diff_comment_fragments
comment.num_lines)),
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 1168, in get_file_chunks_in_range
get_enable_highlighting(context['user']))
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 1032, in get_diff_files
tool = filediff.diffset.repository.get_scmtool()
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/models.py", line 122, in get_scmtool
return cls(self)
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/git.py", line 70, in __init__
local_site_name)
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/git.py", line 307, in __init__
'core.repositoryformatversion'])
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/git.py", line 383, in _run_git
local_site_name=self.local_site_name)
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/core.py", line 122, in popen
close_fds=(os.name != 'nt'))
File "/usr/lib/python2.6/subprocess.py", line 633, in __init__
errread, errwrite)
File "/usr/lib/python2.6/subprocess.py", line 1049, in _execute_child
self.pid = os.fork()
OSError: [Errno 12] Cannot allocate memory
</pre>
</td>
</tr>
</tbody>
</table>
<script type="text/javascript">
/* Add to the change index. */
$("li.change_file_None").html(
'\
<a href="#None" onclick="return !gotoAnchor(\'None\');"></a>\
\
(was language/checks/dataaccess.cpp)\
\
:\
\
Diff currently unavailable.\
\
');
</script>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">also please format it properly (see above)</pre>
</div>
<br />
<div>
<table class="sidebyside diff-error"
id="file_container_40647">
<thead>
<tr>
<th colspan="2" class="filename">
<a href="/r/103071/diff/5/?file=40647#file40647line43">language/checks/dataaccessrepository.h</a>
<span class="diffrevision">
(Diff revision 5)
</span>
</tr>
</thead>
<tbody>
<tr>
<td colspan="2">Diff currently unavailable.</td>
</tr>
<tr>
<td colspan="2"><b>Error:</b> [Errno 12] Cannot allocate memory</td>
</tr>
<tr>
<td colspan="2">
<a id="diff-error-link-40647" href="#"
onclick="$('#diff-error-details-40647').toggle(); return false;">Details</a>
</td>
</tr>
<tr class="error-details" id="diff-error-details-40647">
<td colspan="2">
<pre>Traceback (most recent call last):
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/reviews/views.py", line 177, in build_diff_comment_fragments
comment.num_lines)),
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 1168, in get_file_chunks_in_range
get_enable_highlighting(context['user']))
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 1032, in get_diff_files
tool = filediff.diffset.repository.get_scmtool()
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/models.py", line 122, in get_scmtool
return cls(self)
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/git.py", line 70, in __init__
local_site_name)
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/git.py", line 307, in __init__
'core.repositoryformatversion'])
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/git.py", line 383, in _run_git
local_site_name=self.local_site_name)
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/core.py", line 122, in popen
close_fds=(os.name != 'nt'))
File "/usr/lib/python2.6/subprocess.py", line 633, in __init__
errread, errwrite)
File "/usr/lib/python2.6/subprocess.py", line 1049, in _execute_child
self.pid = os.fork()
OSError: [Errno 12] Cannot allocate memory
</pre>
</td>
</tr>
</tbody>
</table>
<script type="text/javascript">
/* Add to the change index. */
$("li.change_file_None").html(
'\
<a href="#None" onclick="return !gotoAnchor(\'None\');"></a>\
\
(was language/checks/dataaccessrepository.h)\
\
:\
\
Diff currently unavailable.\
\
');
</script>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">spaces around operator please :)</pre>
</div>
<br />
<div>
<table class="sidebyside diff-error"
id="file_container_40648">
<thead>
<tr>
<th colspan="2" class="filename">
<a href="/r/103071/diff/5/?file=40648#file40648line29">language/checks/dataaccessrepository.cpp</a>
<span class="diffrevision">
(Diff revision 5)
</span>
</tr>
</thead>
<tbody>
<tr>
<td colspan="2">Diff currently unavailable.</td>
</tr>
<tr>
<td colspan="2"><b>Error:</b> [Errno 12] Cannot allocate memory</td>
</tr>
<tr>
<td colspan="2">
<a id="diff-error-link-40648" href="#"
onclick="$('#diff-error-details-40648').toggle(); return false;">Details</a>
</td>
</tr>
<tr class="error-details" id="diff-error-details-40648">
<td colspan="2">
<pre>Traceback (most recent call last):
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/reviews/views.py", line 177, in build_diff_comment_fragments
comment.num_lines)),
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 1168, in get_file_chunks_in_range
get_enable_highlighting(context['user']))
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 1032, in get_diff_files
tool = filediff.diffset.repository.get_scmtool()
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/models.py", line 122, in get_scmtool
return cls(self)
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/git.py", line 70, in __init__
local_site_name)
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/git.py", line 307, in __init__
'core.repositoryformatversion'])
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/git.py", line 383, in _run_git
local_site_name=self.local_site_name)
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.1-py2.6.egg/reviewboard/scmtools/core.py", line 122, in popen
close_fds=(os.name != 'nt'))
File "/usr/lib/python2.6/subprocess.py", line 633, in __init__
errread, errwrite)
File "/usr/lib/python2.6/subprocess.py", line 1049, in _execute_child
self.pid = os.fork()
OSError: [Errno 12] Cannot allocate memory
</pre>
</td>
</tr>
</tbody>
</table>
<script type="text/javascript">
/* Add to the change index. */
$("li.change_file_None").html(
'\
<a href="#None" onclick="return !gotoAnchor(\'None\');"></a>\
\
(was language/checks/dataaccessrepository.cpp)\
\
:\
\
Diff currently unavailable.\
\
');
</script>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">rtrim please :)</pre>
</div>
<br />
<p>- Milian</p>
<br />
<p>On November 8th, 2011, 2:03 a.m., Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop, Milian Wolff and David Nolden.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Nov. 8, 2011, 2:03 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As some of you will know, my master thesis was built on top of kdevelop with the idea to add some static analysis capabilities to KDevelop/KDevPlatform by adding some new tools and stuff. A document describing what I did can be found here: http://proli.net/meu/pfc/memoria.pdf
In this patch there's the changes I made in the KDevPlatform, mostly to add the DataAccessRepository and the ControlFlowGraph (Chapter 2) data types and the ILanguageCheck and ILanguageCheck provider (Chapter 3).
If there's any question just ask me :). I'll submit another patch for KDevelop, implementing these features shortly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, the testing is what I've built on top. It's coming, I'm just fixing some issues after merging from master. It wasn't as bad as I expected though ;).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/CMakeLists.txt <span style="color: grey">(eb85b2c)</span></li>
<li>language/backgroundparser/parsejob.h <span style="color: grey">(135319c)</span></li>
<li>language/checks/controlflowgraph.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/checks/controlflowgraph.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/checks/controlflownode.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/checks/controlflownode.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/checks/dataaccess.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/checks/dataaccess.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/checks/dataaccessrepository.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/checks/dataaccessrepository.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103071/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>