Review Request: Checking infrastructure for the KDevPlatform

[David Nolden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103071/#review8022
-----------------------------------------------------------


I am not convinced that this should be added to kdevplatform. The problem is that the duchain API is too complex already and hard to maintain, it needs some cleaning up rather than adding new stuff.

The use-cases of the added classes seem very specific, and it's very unprobable that other languages will implement this level of information-detail, so why cannot this stuff be stored separately together with the C++ specific checker code?

In general, we have to see how much of your thesis we can integrate into kdevelop. For example, the "imports" check could be integrated either as a simple "Problem", or as a "Cleanup Imports" action in the "Code" menu. IMO the most useful and simple checks should be integrated seamlessly in such ways, rather than adding a separate "checker" UI. We have to keep the maintainability of the whole code in mind though, so the complexity of added code has always to be weighted against its usefulnes.

- David Nolden


On Nov. 8, 2011, 2:03 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103071/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2011, 2:03 a.m.)
> 
> 
> Review request for KDevelop, Milian Wolff and David Nolden.
> 
> 
> Description
> -------
> 
> As some of you will know, my master thesis was built on top of kdevelop with the idea to add some static analysis capabilities to KDevelop/KDevPlatform by adding some new tools and stuff. A document describing what I did can be found here: http://proli.net/meu/pfc/memoria.pdf
> 
> In this patch there's the changes I made in the KDevPlatform, mostly to add the DataAccessRepository and the ControlFlowGraph (Chapter 2) data types and the ILanguageCheck and ILanguageCheck provider (Chapter 3).
> 
> If there's any question just ask me :). I'll submit another patch for KDevelop, implementing these features shortly.
> 
> 
> Diffs
> -----
> 
>   language/CMakeLists.txt eb85b2c 
>   language/backgroundparser/parsejob.h 135319c 
>   language/checks/controlflowgraph.h PRE-CREATION 
>   language/checks/controlflowgraph.cpp PRE-CREATION 
>   language/checks/controlflownode.h PRE-CREATION 
>   language/checks/controlflownode.cpp PRE-CREATION 
>   language/checks/dataaccess.h PRE-CREATION 
>   language/checks/dataaccess.cpp PRE-CREATION 
>   language/checks/dataaccessrepository.h PRE-CREATION 
>   language/checks/dataaccessrepository.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103071/diff/diff
> 
> 
> Testing
> -------
> 
> Well, the testing is what I've built on top. It's coming, I'm just fixing some issues after merging from master. It wasn't as bad as I expected though ;).
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111108/dc2965a0/attachment.html>