[PATCH] fix build errors in kdevplatform-1.2.0

[Aleix Pol]

On Sun, Mar 27, 2011 at 10:14 PM, Erik <esigra at gmail.com> wrote:

> This patch fixes the following errors in kdevplatform 1.2.0 so that it can
> be built:
> * Define metatypes in header files and include them instead of having
> multiple Q_DECLARE_METATYPE(TYPE) for the same TYPE (see
> http://www.mail-archive.com/kde-core-devel@kde.org/msg00416.html).
> * Explicit static casts where needed according to the compiler.
> * Define urlToData in one place only (a separate new header file).
> * Rename one of the functions appendActions to appendContextMenuActions to
> make the signature unique.
> * Add include guard to greputil.h
> * Rename one of the structs Visitor to selfAnalysisVisitor to make the
> identifier unique.
> * Use a unique include guard in appendlist_static.h (not the same as in
> appendlist.h)
> * Undefine the macro "mix" after use to not pollute the namespace.
>
>
> --
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>
>
Under what circumstances is all this necessary?

Why do you static_cast<Qt::ItemFlags> to create the enum? It has never been
needed...

All in all, I'd prefer to be able to discuss every change over reviewboard,
As suggested by Andrey.

Aleix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110328/c3e4e3ed/attachment.html>