[PATCH] fix build errors in kdevplatform-1.2.0

[Andrey Batyiev]

Hello

On Sun, Mar 27, 2011 at 11:14 PM, Erik <esigra at gmail.com> wrote:
> This patch fixes the following errors in kdevplatform 1.2.0 so that it can
> be built:

There is a nice patch review interface at http://git.reviewboard.kde.org/.
Please use it.

What do you mean 'it can be built'? Do you mean it doesn't build with
-DKDE4_ENABLE_FINAL?

> * Define urlToData in one place only (a separate new header file).

IMHO, it should be put inside util directory.

> * Undefine the macro "mix" after use to not pollute the namespace.

Why did you undefine only "mix" macro? There are several other macros in that
file.


Thanks,
   Andrey