[PATCH] fix build errors in kdevplatform-1.2.0

[Milian Wolff]

Erik, 27.03.2011:
> This patch fixes the following errors in kdevplatform 1.2.0 so that it
> can be built:

as the others said, please put on reviewboard. If possible, split the patch 
into logical chunks so they can easily be reviewed separately.

> * Define metatypes in header files and include them instead of having
> multiple Q_DECLARE_METATYPE(TYPE) for the same TYPE (see
> http://www.mail-archive.com/kde-core-devel@kde.org/msg00416.html).

put the Q_DECLARE_METATYPE into the header of the type, instead of creating a 
new metatype header.

> * Explicit static casts where needed according to the compiler.

what compiler? it works for all of us (also on windows and mac afair).

> * Define urlToData in one place only (a separate new header file).

fine with me

> * Rename one of the functions appendActions to appendContextMenuActions
> to make the signature unique.

rather put it into a anonymous namespace

namespace {
...
}

> * Add include guard to greputil.h

fine with me

> * Rename one of the structs Visitor to selfAnalysisVisitor to make the
> identifier unique.

again, anon namespace

> * Use a unique include guard in appendlist_static.h (not the same as in
> appendlist.h)

fine with me

> * Undefine the macro "mix" after use to not pollute the namespace.

why only this and not also the other defines?
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110329/4668f0b1/attachment.sig>