Review Request: Fix standard include dirs and macros under Windows

[Aleix Pol Gonzalez]

> On March 7, 2011, 8:45 a.m., Aleix Pol Gonzalez wrote:
> > Maybe it would be interesting to have a winport branch with all these changes so that we can merge it all together when you're happy with the result. :)
> 
> Milian Wolff wrote:
>     to what gain? each of these review requests alone make kdevelop more useable on windows, so I'm fine with merging them early. It's also simpler to review that way.

The gain of properly abstracting against a different architecture instead of just patching and ifdef'ing our code to a work-ish state on windows...


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100801/#review1829
-----------------------------------------------------------


On March 6, 2011, 10:25 a.m., Andreas Holzammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100801/
> -----------------------------------------------------------
> 
> (Updated March 6, 2011, 10:25 a.m.)
> 
> 
> Review request for KDevelop, kdewin, Milian Wolff, and Patrick Spendrin.
> 
> 
> Summary
> -------
> 
> This patch enables Kdevelop to find the include directories and standard macros under Windows.
> 
> There is no "gcc -dM -E -" under Windows. So you need to do a hack to find the standard defined macros. Therefore a empty cpp file is compiled with a special commandline option "/Bx" to replace the compiler against a program which interpretes the output of the preprocessor.
> 
> For include directories Windows uses enviroment variables, so this patch processes them.
> 
> This patch has been written by Patrick Spenderin, thank you for that.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/CMakeLists.txt e7c3c0c07ac3ac0ad5b49c60b0d0c279b77e8e75 
>   languages/cpp/msvcdefinehelper.cpp PRE-CREATION 
>   languages/cpp/parser/rpp/chartools.cpp 7fecf1ef2df8ce7e52f8afd2f847dfc746ecd2fc 
>   languages/cpp/setuphelpers.cpp b35ec8386a2c04a7caa421be9bf8e0d268f1213a 
>   languages/cpp/setuphelpers_gcc.cpp PRE-CREATION 
>   languages/cpp/setuphelpers_msvc.cpp PRE-CREATION 
>   languages/cpp/tests/CMakeLists.txt e3b7add33e9f89b96ae8f86da3cc240647cd99a4 
>   projectmanagers/cmake/cmakedocumentation.cpp b4679051fb3ad3e9a4a664f79a1844058f4d8fb5 
> 
> Diff: http://git.reviewboard.kde.org/r/100801/diff
> 
> 
> Testing
> -------
> 
> tested it with Windows 7 Ultimate x64 with KDE Windows trunk compiled with MSVC 2010. Works so far.
> 
> 
> Thanks,
> 
> Andreas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110308/add347d2/attachment.html>