<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100801/">http://git.reviewboard.kde.org/r/100801/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 7th, 2011, 8:45 a.m., <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe it would be interesting to have a winport branch with all these changes so that we can merge it all together when you're happy with the result. :)</pre>
</blockquote>
<p>On March 7th, 2011, 10:20 a.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">to what gain? each of these review requests alone make kdevelop more useable on windows, so I'm fine with merging them early. It's also simpler to review that way.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The gain of properly abstracting against a different architecture instead of just patching and ifdef'ing our code to a work-ish state on windows...</pre>
<br />
<p>- Aleix</p>
<br />
<p>On March 6th, 2011, 10:25 a.m., Andreas Holzammer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop, kdewin, Milian Wolff, and Patrick Spendrin.</div>
<div>By Andreas Holzammer.</div>
<p style="color: grey;"><i>Updated March 6, 2011, 10:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch enables Kdevelop to find the include directories and standard macros under Windows.
There is no "gcc -dM -E -" under Windows. So you need to do a hack to find the standard defined macros. Therefore a empty cpp file is compiled with a special commandline option "/Bx" to replace the compiler against a program which interpretes the output of the preprocessor.
For include directories Windows uses enviroment variables, so this patch processes them.
This patch has been written by Patrick Spenderin, thank you for that.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested it with Windows 7 Ultimate x64 with KDE Windows trunk compiled with MSVC 2010. Works so far.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/CMakeLists.txt <span style="color: grey">(e7c3c0c07ac3ac0ad5b49c60b0d0c279b77e8e75)</span></li>
<li>languages/cpp/msvcdefinehelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/cpp/parser/rpp/chartools.cpp <span style="color: grey">(7fecf1ef2df8ce7e52f8afd2f847dfc746ecd2fc)</span></li>
<li>languages/cpp/setuphelpers.cpp <span style="color: grey">(b35ec8386a2c04a7caa421be9bf8e0d268f1213a)</span></li>
<li>languages/cpp/setuphelpers_gcc.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/cpp/setuphelpers_msvc.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/cpp/tests/CMakeLists.txt <span style="color: grey">(e3b7add33e9f89b96ae8f86da3cc240647cd99a4)</span></li>
<li>projectmanagers/cmake/cmakedocumentation.cpp <span style="color: grey">(b4679051fb3ad3e9a4a664f79a1844058f4d8fb5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100801/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>