Review Request: Fix standard include dirs and macros under Windows

[Patrick Spendrin]

> On March 5, 2011, 5:47 p.m., Milian Wolff wrote:
> > languages/cpp/CMakeLists.txt, line 60
> > <http://git.reviewboard.kde.org/r/100801/diff/1/?file=10582#file10582line60>
> >
> >     what about only adding the _gcc version in the else branch?

well, the compiler that is used for building kdevelop is not necessarily the one used for building the projects (at least it won't be in the future).


- Patrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100801/#review1779
-----------------------------------------------------------


On March 5, 2011, 4:21 p.m., Andreas Holzammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100801/
> -----------------------------------------------------------
> 
> (Updated March 5, 2011, 4:21 p.m.)
> 
> 
> Review request for KDevelop, kdewin, Milian Wolff, and Patrick Spendrin.
> 
> 
> Summary
> -------
> 
> This patch enables Kdevelop to find the include directories and standard macros under Windows.
> 
> There is no "gcc -dM -E -" under Windows. So you need to do a hack to find the standard defined macros. Therefore a empty cpp file is compiled with a special commandline option "/Bx" to replace the compiler against a program which interpretes the output of the preprocessor.
> 
> For include directories Windows uses enviroment variables, so this patch processes them.
> 
> This patch has been written by Patrick Spenderin, thank you for that.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/CMakeLists.txt e7c3c0c07ac3ac0ad5b49c60b0d0c279b77e8e75 
>   languages/cpp/msvcdefinehelper.cpp PRE-CREATION 
>   languages/cpp/setuphelpers.cpp b35ec8386a2c04a7caa421be9bf8e0d268f1213a 
>   languages/cpp/setuphelpers_gcc.cpp PRE-CREATION 
>   languages/cpp/setuphelpers_msvc.cpp PRE-CREATION 
>   languages/cpp/tests/CMakeLists.txt e3b7add33e9f89b96ae8f86da3cc240647cd99a4 
> 
> Diff: http://git.reviewboard.kde.org/r/100801/diff
> 
> 
> Testing
> -------
> 
> tested it with Windows 7 Ultimate x64 with KDE Windows trunk compiled with MSVC 2010. Works so far.
> 
> 
> Thanks,
> 
> Andreas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110305/1265c4e3/attachment.html>