Review Request: Fix MakeOutput items for cmake builds with relative paths

Manuel Massing m.massing at warped-space.de
Thu Mar 3 10:52:34 UTC 2011


Hi,

> > shortenedText is not being set for any of the cmake ActionItems, because
> > toolIndex == -1 (in that case, shortenedText defaults to the full output
> > line).

> that changes the behavior of compiling: now it will only match up to
> excluding /CmakeFiles which is wrong. And of course for non-cmake build
> systems it will fail alltogether as the string "CMakeFiles" won't be
> included.

No, not a problem. As I said, the captured expression is not used at
all (other than for the build directory parsing), and the regex is specific to
cmake - it will not affect the matching of any other regular expression, e.g.
for a standard Makefile based build.

	Manuel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110303/53625a7a/attachment.html>


More information about the KDevelop-devel mailing list