Review Request: Fix MakeOutput items for cmake builds with relative paths

Milian Wolff mail at milianw.de
Thu Mar 3 12:29:53 UTC 2011


Manuel Massing, 03.03.2011:
> Hi,
> 
> > > shortenedText is not being set for any of the cmake ActionItems,
> > > because toolIndex == -1 (in that case, shortenedText defaults to the
> > > full output line).
> > 
> > that changes the behavior of compiling: now it will only match up to
> > excluding /CmakeFiles which is wrong. And of course for non-cmake build
> > systems it will fail alltogether as the string "CMakeFiles" won't be
> > included.
> 
> No, not a problem. As I said, the captured expression is not used at
> all (other than for the build directory parsing), and the regex is specific
> to cmake - it will not affect the matching of any other regular
> expression, e.g. for a standard Makefile based build.

ah ok then I'm fine with that.

bye
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110303/fb30f770/attachment-0001.sig>


More information about the KDevelop-devel mailing list