Review Request: Fix MakeOutput items for cmake builds with relative paths

Manuel Massing m.massing at warped-space.de
Thu Mar 3 00:44:12 UTC 2011


Hi Milian,

> So that string is user-visible after all?

I'm not sure if they are actually displayed somewhere, but the
shortenedText is not being set for any of the cmake ActionItems, because 
toolIndex == -1 (in that case, shortenedText defaults to the full output
line).

But looking at the code again, I think the "potential_cd" could be
removed... see attached patch, which cleans things up a bit.

The unsermake regexps seem to be off btw (at least "linking" and "compiling" 
use capture indices which do not exist).	

cheers,

	Manuel


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110303/7db4067a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cmake-output-parsing-remove-potential_cd-ActionItem.patch
Type: text/x-patch
Size: 3320 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110303/7db4067a/attachment.patch>


More information about the KDevelop-devel mailing list