Review Request: Compilation fix on windows

[Andreas Pakulat]

> On July 8, 2011, 1:10 p.m., Milian Wolff wrote:
> > ok, fine with me. but could you also take a look at the history on why someone added that initially? maybe it was required to get something to work? does the cmake stuff work on windows now?

The problem is that nobody ever builds on windows, otherwise this would've been found around the time when the instpath local variable was removed. I had already looked this up when Charles asked about this in IRC, the code once had a local variable - though I didn't quite understand what it does - but that was removed at some point, but the windows-part of the ifdef was not updated to reflect that change.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101870/#review4525
-----------------------------------------------------------


On July 6, 2011, 10:06 p.m., Charles Huet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101870/
> -----------------------------------------------------------
> 
> (Updated July 6, 2011, 10:06 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This fixes windows compilation by removing a reference to a variable named instpath.
> As this was the only difference between the code in the #ifdef Q_OS_WIN and the #else, I removed the #ifdef entirely.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/parser/cmakeprojectvisitor.cpp 6a2ad5b 
> 
> Diff: http://git.reviewboard.kde.org/r/101870/diff
> 
> 
> Testing
> -------
> 
> Actually compiles on windows now
> 
> 
> Thanks,
> 
> Charles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110708/af85ed3a/attachment.html>