Review Request: Compilation fix on windows

Aleix Pol Gonzalez aleixpol at gmail.com
Fri Jul 8 13:13:26 UTC 2011



> On None, Charles Huet wrote:
> >

why is instPath bad?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101870/#review4478
-----------------------------------------------------------


On July 6, 2011, 10:06 p.m., Charles Huet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101870/
> -----------------------------------------------------------
> 
> (Updated July 6, 2011, 10:06 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This fixes windows compilation by removing a reference to a variable named instpath.
> As this was the only difference between the code in the #ifdef Q_OS_WIN and the #else, I removed the #ifdef entirely.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/parser/cmakeprojectvisitor.cpp 6a2ad5b 
> 
> Diff: http://git.reviewboard.kde.org/r/101870/diff
> 
> 
> Testing
> -------
> 
> Actually compiles on windows now
> 
> 
> Thanks,
> 
> Charles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110708/428ed2b1/attachment.html>


More information about the KDevelop-devel mailing list