Review Request: Compilation fix on windows

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101870/#review4525
-----------------------------------------------------------


ok, fine with me. but could you also take a look at the history on why someone added that initially? maybe it was required to get something to work? does the cmake stuff work on windows now?

- Milian


On July 6, 2011, 10:06 p.m., Charles Huet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101870/
> -----------------------------------------------------------
> 
> (Updated July 6, 2011, 10:06 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This fixes windows compilation by removing a reference to a variable named instpath.
> As this was the only difference between the code in the #ifdef Q_OS_WIN and the #else, I removed the #ifdef entirely.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/parser/cmakeprojectvisitor.cpp 6a2ad5b 
> 
> Diff: http://git.reviewboard.kde.org/r/101870/diff
> 
> 
> Testing
> -------
> 
> Actually compiles on windows now
> 
> 
> Thanks,
> 
> Charles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110708/69de01fb/attachment.html>