Review Request: Fix MakeOutput items for cmake builds with relative paths

[David Nolden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100745/#review1658
-----------------------------------------------------------


There's a slight problem with the "currentDirs" thing. From what I remember, the order within currentDirs is important, and thus, the most recently encountered dir should always be at the end. So the best solution would be, checking whether the dir is already there, and if yes, removing it, then re-appending it to the end.
However, maybe a "currentDirs.back() == dir" check would be enough anyway? Usually, directories are processed sequentially one by one, not multiple in parallel.

As a bonus, it would be great if we had some tests for this, although I'm not sure how those should be created.

- David


On Feb. 26, 2011, 12:36 a.m., Manuel Massing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100745/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2011, 12:36 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Fixes MakeOutput items for cmake builds which use relative paths 
> (i.e. cmake projects with CMAKE_USE_RELATIVE_PATHS set to on).
> 
> Previously, errors generated by source files with relativ paths
> were not clickable because MakeOutputModel does not know about
> the directories they are built in.
> 
> Because cmake is not verbose enough to indicate directory changes,
> observes where object files are being built and use these paths
> as search path for urlToFile.
> 
> 
> Diffs
> -----
> 
>   projectbuilders/makebuilder/makeoutputmodel.h 5ac45535a0d6d5496c48631d281e322c7b1b792e 
>   projectbuilders/makebuilder/makeoutputmodel.cpp 09bb72e4621e8033666d6c0c36c1fc34834754a9 
>   projectbuilders/makebuilder/outputfilters.cpp 3b6b806d73375daf85831f734153a5bf4e2293d6 
> 
> Diff: http://git.reviewboard.kde.org/r/100745/diff
> 
> 
> Testing
> -------
> 
> Tested on cmake project with SET(CMAKE_USE_RELATIVE_PATHS ON).
> 
> 
> Thanks,
> 
> Manuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110226/f8367ab9/attachment.html>