Review Request: Fix MakeOutput items for cmake builds with relative paths

Manuel Massing m.massing at
Sat Feb 26 00:36:24 UTC 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 26, 2011, 12:36 a.m.)

Review request for KDevelop.


Squash previous commits into a single patch, remove some trailing whitespace while I am at it.


Fixes MakeOutput items for cmake builds which use relative paths 
(i.e. cmake projects with CMAKE_USE_RELATIVE_PATHS set to on).

Previously, errors generated by source files with relativ paths
were not clickable because MakeOutputModel does not know about
the directories they are built in.

Because cmake is not verbose enough to indicate directory changes,
observes where object files are being built and use these paths
as search path for urlToFile.

Diffs (updated)

  projectbuilders/makebuilder/makeoutputmodel.h 5ac45535a0d6d5496c48631d281e322c7b1b792e 
  projectbuilders/makebuilder/makeoutputmodel.cpp 09bb72e4621e8033666d6c0c36c1fc34834754a9 
  projectbuilders/makebuilder/outputfilters.cpp 3b6b806d73375daf85831f734153a5bf4e2293d6 



Tested on cmake project with SET(CMAKE_USE_RELATIVE_PATHS ON).



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list