<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100745/">http://git.reviewboard.kde.org/r/100745/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There's a slight problem with the "currentDirs" thing. From what I remember, the order within currentDirs is important, and thus, the most recently encountered dir should always be at the end. So the best solution would be, checking whether the dir is already there, and if yes, removing it, then re-appending it to the end.
However, maybe a "currentDirs.back() == dir" check would be enough anyway? Usually, directories are processed sequentially one by one, not multiple in parallel.
As a bonus, it would be great if we had some tests for this, although I'm not sure how those should be created.</pre>
<br />
<p>- David</p>
<br />
<p>On February 26th, 2011, 12:36 a.m., Manuel Massing wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Manuel Massing.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2011, 12:36 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes MakeOutput items for cmake builds which use relative paths
(i.e. cmake projects with CMAKE_USE_RELATIVE_PATHS set to on).
Previously, errors generated by source files with relativ paths
were not clickable because MakeOutputModel does not know about
the directories they are built in.
Because cmake is not verbose enough to indicate directory changes,
observes where object files are being built and use these paths
as search path for urlToFile.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on cmake project with SET(CMAKE_USE_RELATIVE_PATHS ON).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectbuilders/makebuilder/makeoutputmodel.h <span style="color: grey">(5ac45535a0d6d5496c48631d281e322c7b1b792e)</span></li>
<li>projectbuilders/makebuilder/makeoutputmodel.cpp <span style="color: grey">(09bb72e4621e8033666d6c0c36c1fc34834754a9)</span></li>
<li>projectbuilders/makebuilder/outputfilters.cpp <span style="color: grey">(3b6b806d73375daf85831f734153a5bf4e2293d6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100745/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>