Review Request: Fix MakeOutput items for cmake builds with relative paths
apaku at gmx.de
Sat Feb 26 09:37:41 UTC 2011
On 26.02.11 01:43:40, Manuel Massing wrote:
> > There's no way to have multiple patches in one review, except for
> > versions of the same patch, AFAIK, so you'll have to send the change
> > as a whole. You might want to use post-review tool for this - see
> > http://community.kde.org/Sysadmin/GitKdeOrgManual.
> Ok, thanks Dmitry, I've just squashed the commits into a single patch. The
> missing support for patchsets seems to counter the fine-grained nature of git
> commits a bit but I guess a single patch is easier to review and amend... and,
> on the bright side, "post-review" looks like a nice tool :-)
I think the idea is not to squash the commits, but update the review with
the complete range of commits. If we merge the change we will anyway merge
your branch and not apply the reviewboard patch.
Chicken Little was right.
More information about the KDevelop-devel