Review Request: Fix MakeOutput items for cmake builds with relative paths

Manuel Massing m.massing at
Fri Feb 25 18:17:56 UTC 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 25, 2011, 6:17 p.m.)

Review request for KDevelop.


Use hash table (via QSet) instead of checking the string list for containment, to avoid O(n^2) runtime behaviour.


Fixes MakeOutput items for cmake builds which use relative paths 
(i.e. cmake projects with CMAKE_USE_RELATIVE_PATHS set to on).

Previously, errors generated by source files with relativ paths
were not clickable because MakeOutputModel does not know about
the directories they are built in.

Because cmake is not verbose enough to indicate directory changes,
observes where object files are being built and use these paths
as search path for urlToFile.

Diffs (updated)

  projectbuilders/makebuilder/makeoutputmodel.h 5ac4553 
  projectbuilders/makebuilder/makeoutputmodel.cpp 09bb72e 



Tested on cmake project with SET(CMAKE_USE_RELATIVE_PATHS ON).



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list