Review Request: Fix crash when KTextEdit::Factory is not found

[Robert Mathias Marmorstein]

> On March 28, 2011, 8:25 a.m., Milian Wolff wrote:
> > can you give me a backtrace of the crash that happened before?
> > 
> > I'd rather have an explicit exit(1) or similar at the place where we check for the text part and show the error box instead of catching this error here.

Application: Quanta (quanta), signal: Segmentation fault
[KCrash Handler]
#6  0x00007f146c4bbfa4 in KDevelop::PartController::createTextPart (this=0x1cde1f0, encoding=...) at /var/abs/local/eth-os/sources/KDE/kdevplatform/shell/partcontroller.cpp:133
#7  0x00007f146c4ad716 in KDevelop::CorePrivate::initialize (this=0x1c27bb0, mode=KDevelop::Core::Default, session=...) at /var/abs/local/eth-os/sources/KDE/kdevplatform/shell/core.cpp:126
#8  0x00007f146c4adeac in KDevelop::Core::initialize (splash=0x1c25800, mode=KDevelop::Core::Default, session=...) at /var/abs/local/eth-os/sources/KDE/kdevplatform/shell/core.cpp:275
#9  0x00000000004044f7 in main (argc=<value optimized out>, argv=<value optimized out>) at /var/abs/local/eth-os/sources/KDE/quanta/src/main.cpp:189


- Robert Mathias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100949/#review2201
-----------------------------------------------------------


On March 26, 2011, 7:56 a.m., Robert Mathias Marmorstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100949/
> -----------------------------------------------------------
> 
> (Updated March 26, 2011, 7:56 a.m.)
> 
> 
> Review request for KDevelop and Quanta.
> 
> 
> Summary
> -------
> 
> This patch fixes a crash which occurs when closing kdevelop or quanta after the "KTextEditor::Factory not found" error box is displayed.  The problem is a simple logic error caused by the fact that QApplicationCore::exit() does not immediately abort an application.  Instead, it causes event processing to cease, which indirectly terminates the application AFTER the function has returned to the main event loop.
> 
> 
> Diffs
> -----
> 
>   shell/partcontroller.cpp 5a81de0 
> 
> Diff: http://git.reviewboard.kde.org/r/100949/diff
> 
> 
> Testing
> -------
> 
> Recompiled, ran quanta and kdevelop.  Error message dialog still comes up (as it should), but the program closes without crashing now.
> 
> 
> Thanks,
> 
> Robert Mathias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110404/73af4cf7/attachment.html>