<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100949/">http://git.reviewboard.kde.org/r/100949/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 28th, 2011, 8:25 a.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">can you give me a backtrace of the crash that happened before?
I'd rather have an explicit exit(1) or similar at the place where we check for the text part and show the error box instead of catching this error here.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Application: Quanta (quanta), signal: Segmentation fault
[KCrash Handler]
#6 0x00007f146c4bbfa4 in KDevelop::PartController::createTextPart (this=0x1cde1f0, encoding=...) at /var/abs/local/eth-os/sources/KDE/kdevplatform/shell/partcontroller.cpp:133
#7 0x00007f146c4ad716 in KDevelop::CorePrivate::initialize (this=0x1c27bb0, mode=KDevelop::Core::Default, session=...) at /var/abs/local/eth-os/sources/KDE/kdevplatform/shell/core.cpp:126
#8 0x00007f146c4adeac in KDevelop::Core::initialize (splash=0x1c25800, mode=KDevelop::Core::Default, session=...) at /var/abs/local/eth-os/sources/KDE/kdevplatform/shell/core.cpp:275
#9 0x00000000004044f7 in main (argc=<value optimized out>, argv=<value optimized out>) at /var/abs/local/eth-os/sources/KDE/quanta/src/main.cpp:189
</pre>
<br />
<p>- Robert Mathias</p>
<br />
<p>On March 26th, 2011, 7:56 a.m., Robert Mathias Marmorstein wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Quanta.</div>
<div>By Robert Mathias Marmorstein.</div>
<p style="color: grey;"><i>Updated March 26, 2011, 7:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes a crash which occurs when closing kdevelop or quanta after the "KTextEditor::Factory not found" error box is displayed. The problem is a simple logic error caused by the fact that QApplicationCore::exit() does not immediately abort an application. Instead, it causes event processing to cease, which indirectly terminates the application AFTER the function has returned to the main event loop.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Recompiled, ran quanta and kdevelop. Error message dialog still comes up (as it should), but the program closes without crashing now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/partcontroller.cpp <span style="color: grey">(5a81de0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100949/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>