Review Request: Fix crash when KTextEdit::Factory is not found

Mon Apr 4 07:35:10 UTC 2011

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100949/
-----------------------------------------------------------

(Updated April 4, 2011, 7:35 a.m.)

Review request for KDevelop and Quanta.

Changes
-------

This explicitly exits when kate (or equivalent) is not found.  I personally think the original patch is cleaner (and safer) code, but this should do what you want.

Summary
-------

This patch fixes a crash which occurs when closing kdevelop or quanta after the "KTextEditor::Factory not found" error box is displayed.  The problem is a simple logic error caused by the fact that QApplicationCore::exit() does not immediately abort an application.  Instead, it causes event processing to cease, which indirectly terminates the application AFTER the function has returned to the main event loop.

Diffs (updated)
-----

  shell/partcontroller.cpp 5a81de0 

Diff: http://git.reviewboard.kde.org/r/100949/diff

Testing
-------

Recompiled, ran quanta and kdevelop.  Error message dialog still comes up (as it should), but the program closes without crashing now.

Thanks,

Robert Mathias

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110404/dc6e4e27/attachment.html>