Git Support ready-ness

[Andreas Pakulat]

On 02.09.10 17:41:41, David Nolden wrote:
> 2010/9/2 Andreas Pakulat <apaku at gmx.de>:
> > On 02.09.10 16:45:49, David Nolden wrote:
> >> The new version of the git support doesn't work any more on my machine.
> >>
> >> The problem:
> >> "git diff ABSOLUTE_PATH" doesn't work (might depend on my git version
> >> 1.5.4.3). The plugin should use the git root directory as
> >> working-directory instead, and use relative paths when calling git.
> >
> > I don't have any such ancient git around, but for me git diff absolute-path
> > works as long as cwd is _somewhere_ in the git-repository. It won't work
> > when cwd is outside of the repo, I've already told Aleix that when he
> > recently did that change, but apparently he either overlooked, didn't get
> > around to fixing it or just ignored me :)
> >
> >> Noone else has noticed this problem?
> >
> > I guess nobody uses ancient git versions 1.7 is current. And I last tested
> > when the above mentioned changed hasn't been done yet...
> 
> Well, some don't have a choice, and this git-version is part of one of
> the oldest still-supported LTS Ubuntu release.

Git is very easy to install from source. How do you use gdb 7.0? Also
there's already an updated version of LTS Ubuntu so an upgrade shouldn't
pose a technical problem. Really, 1.5.4 is >2 years old. We're also not
working with KDE4.2/Qt4.2 or gdb 6.8 anymore.

> In professional environments  the OS is not updated every half year..

Thats actually not true. It depends on who the owner of the machine is
I'm updating my professional machines every once in a while (6-12 months
I think).

> Anyway it seems like the git plugin is completely incompatible with
> this version, for example the "--porcelain" in "git status
> --porcelain" isn't supported. We should define what exact git versions
> the plugin works with, and prevent the usage of the plugin for all
> other versions.

That means 1.6 and later I guess. Somebody will have to add a check and
error info and disable all the code. 

> Also I've been able to trigger some assertions, which should never
> happen in a plugin that works together with possibly-changing
> command-line tools. Before this plugin can be release, I think all
> assertions that are related to git output should be replaced by
> warnings (for example Q_ASSERT(ret && job->status() ==
> VcsJob::JobSucceeded && etc.)

Then get started ;) Its part of kdevplatform now, so it will be released
together with 4.1. 

> I've also converted the git plugin to use relative paths everywhere,
> I'm sending the patch, no clue if it's maybe useful with some newer
> but not-perfectly-new git version or something like that.

That is not necessary, its enough to have the working dir set to the
project dir (or a subdir) with the above mentioned 1.6 version of git.

Andreas

-- 
You will be the last person to buy a Chrysler.