Patch: pluralize removeFile/removeFolder API
Olivier JG
olivier.jg at gmail.com
Wed Oct 13 23:55:57 UTC 2010
On 10/13/2010 11:38 PM, Aleix Pol wrote:
> API wise:
> - You can't call it removeFilesAndFolders and pass ProjectBaseItem's
> because there might be targets there too (target removal doesn't work
> with cmake yet, though, but we could add that easy). Maybe removeItems()?
That was my idea originally, but then I noticed that removeTarget is in
IBuildSystemManager. IOW, from the API point of view, as it stands,
removing files/folders and targets are two different things. I asked
Milian and he said to keep it that way and go with removeFIlesAndFolders.
As far as what to do, currently the ProjectManagers get a nice clean
list of only folders and files passed to removeFilesAndFolders, and as
long as it stays that way, it's not an issue. Perhaps I should ASSERT
that stance though?
Thanks for reviewing
-Olivier JG
More information about the KDevelop-devel
mailing list