Patch: pluralize removeFile/removeFolder API

[Aleix Pol]

On Wed, Oct 13, 2010 at 5:13 PM, Olivier JG <olivier.jg at gmail.com> wrote:

>  Attached are new patches for kdevelop and kdevplatform. Egregious errors
> can be attributed to time of night.
> Now, deleting a folder will have any subfiles removed from targets as
> needed, and the api is removeFilesAndFolders.
> Known issue is that the remove option shouldn't be present when removing
> target subfiles or the project dir (gasp), this is currently worked around
> for safety and cleanliness. Once this goes in, I'll take a look at fixing
> the context menu.
> -Olivier JG
>
>
> --
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>
>
API wise:
- You can't call it removeFilesAndFolders and pass ProjectBaseItem's because
there might be targets there too (target removal doesn't work with cmake
yet, though, but we could add that easy). Maybe removeItems()?

On KDevelop patch:
- can you add const & on the parameters? All the rest of the code is using
it, we won't change that just for this case
- instead of passing parameters as class&, pass them as pointers, it's how
we usually work with widgets and looks more clear imo.

But this is more like small comments, I think the patches are good globally.
Aleix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101013/1c14dd85/attachment.html>